Hi Hoegeun,
On 09.06.2017 06:59, Hoegeun Kwon wrote:
> The Samsung s6e63j0x03 is a 1.63" 320x320 AMOLED panel connected using
> MIPI-DSI interfaces.
>
> Signed-off-by: Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx>
> ---
> .../bindings/display/panel/samsung,s6e63j0x03.txt | 24 ++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e63j0x03.txt
>
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e63j0x03.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e63j0x03.txt
> new file mode 100644
> index 0000000..34b6e2a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e63j0x03.txt
> @@ -0,0 +1,24 @@
> +Samsung S6E63J0X03 1.63" 320x320 AMOLED panel
Maybe it would be good to add info about interface, "MIPI DSI command
mode" I suppose.
> +
> +Required properties:
> + - compatible: "samsung,s6e63j0x03"
> + - reg: the virtual channel number of a DSI peripheral
> + - vdd3-supply: I/O voltage supply
> + - vci-supply: voltage supply for analog circuits
> + - reset-gpios: a GPIO spec for the reset pin (active high)
Usually reset gpios is active low, also driver code suggests it, if it
is true please fix example also.
With above comments addressed:
Reviewed-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>
--
Regards
Andrzej
> + - te-gpios: a GPIO spec for the tearing effect synchronization signal
> + gpio pin (active high)
> +
> +Example:
> +&dsi {
> + ...
> +
> + panel@0 {
> + compatible = "samsung,s6e63j0x03";
> + reg = <0>;
> + vdd3-supply = <&ldo16_reg>;
> + vci-supply = <&ldo20_reg>;
> + reset-gpios = <&gpe0 1 GPIO_ACTIVE_HIGH>;
> + te-gpios = <&gpx0 6 GPIO_ACTIVE_HIGH>;
> + };
> +};
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
