On 09/06/17 16:10, Russell King - ARM Linux wrote: > On Fri, Jun 09, 2017 at 03:56:39PM +0200, Neil Armstrong wrote: >> Yes, but on the Amlogic Meson plarform, the DW-HDMI CEC controller is >> not used, but a custom one, so this notifier is actually useful for >> this platform and maybe others. > > Is the CEC controller configured into dw-hdmi (is the config bit set?) > I'm just wondering if we're going to end up with two CEC drivers trying > to bind to the same notifier. > >> Should we really wait until I push the Amlogic AO CEC driver ? Having a >> notifier in the DW-HDMI driver won't harm anybody since it *will be used*. > > It sounds like this adds additional information that has been missing > from the review of my patches - and I suspect changes Hans' comments. > So, I'll wait, it seems pointless to try and update the patches when > it's not clear how to proceed due to other dependencies, especially > when it means that their existing state is what's required (I'm pleased > that I've held off modifying the patches so far.) > > If that means having to wait another kernel revision, then I guess that's > what will have to happen. > I've Acked patches 1-3. Patch 4 can be rebased on top of the latest mainline and just ignore any notifier-related comments I made in my review of this patch. I have no problem with patches 1-3 being merged now. Regards, Hans _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
