On Fri, May 26, 2017 at 08:57:32AM +0200, Daniel Vetter wrote: > On Thu, May 25, 2017 at 5:01 AM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > > On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: > >> It again looks all cargo-culted for no good reasons. > > > > drm_vblank_cleanup() is called to release the resources allocated by > > drm_vblank_init(). I think that's the reason, no? > > Pls read the code and the last patch in this series. The drm core > already calls drm_vblank_cleanup for you, the only reason it was > exported was to handle certain usersmodesetting fallback scenarios in > radeon.ko. Ah, okay. The drm_dev_unref() in the error and unbind path will eventually triggers drm_dev_fini() where drm_vblank_cleanup() will get called. Thanks for the hint. FWIW, Acked-by: Shawn Guo <shawnguo@xxxxxxxxxx> _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
