On Wed, May 24, 2017 at 04:19:31PM +0100, Chris Wilson wrote: > On Wed, May 24, 2017 at 04:51:35PM +0200, Daniel Vetter wrote: > > Hi all, > > > > So the first part of this patch series is the usual deal of decrufting some part > > of drm and attempting to improve the docs. Mostly around vblank. I seem to be > > the ever constant 5% of finally being able to document drm_driver/device > > properly, oh well. > > > > By patch count the bigger part is trying to get rid of drm_vblank_cleanup. That > > was initially exported to drivers for a radeon ums irq failover hack, and then > > seems to have been cargo-culted all over the place. It's a bit of churn, but it > > will get us one step closer to tracking vblanks as part of drm_crtc. The other > > bit would be to get rid of drm_vblank_init, and instead auto-setup the relevant > > vblank stuff in drm_crtc_init (iff the driver supports vblanks ofc). > > Whilst I laud the motive, afaict drm_vblank_cleanup() is still required > after drm_vblank_init(), if only to kfree(dev->vblank). I didn't see > that change in the earlier patches... drm_dev_release -> drm_dev_fini -> drm_vblank_cleanup, and has been there even before drm_vblank_cleanup was exported to drivers (which only happened recent-ish, see the last patch). I should probably dump some of the history digging into the earlier patches, atm the patch series reads a bit backwards :-/ Or did I miss something in my auditing? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
