Hi, Nickey: Sorry for the late reply. I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1. Regards, CK On Tue, 2017-03-21 at 16:27 +0800, Nickey Yang wrote: > mtk_hdmi_setup_vendor_specific_infoframe will return before handle > mtk_hdmi_hw_send_info_frame.Because hdmi_vendor_infoframe_pack > returns the number of bytes packed into the binary buffer or > a negative error code on failure. > So correct it. > > Signed-off-by: Nickey Yang <nickey.yang@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > index c262512..b43aa29 100644 > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > @@ -1062,7 +1062,7 @@ static int mtk_hdmi_setup_vendor_specific_infoframe(struct mtk_hdmi *hdmi, > } > > err = hdmi_vendor_infoframe_pack(&frame, buffer, sizeof(buffer)); > - if (err) { > + if (err < 0) { > dev_err(hdmi->dev, "Failed to pack vendor infoframe: %zd\n", > err); > return err; _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel