On 05/19/2017 09:49 AM, Julia Lawall wrote: > On line 466, the preceeding comment suggests that the second constant > should start with VS rather than HS again. > > julia > > ---------- Forwarded message ---------- > Date: Fri, 19 May 2017 15:45:39 +0800 > From: kbuild test robot <fengguang.wu@xxxxxxxxx> > To: kbuild@xxxxxx > Cc: Julia Lawall <julia.lawall@xxxxxxx> > Subject: Re: [PATCH] drm/stm: add COMPILE_TEST to Kconfig > > CC: kbuild-all@xxxxxx > In-Reply-To: <1495082711-10535-1-git-send-email-yamada.masahiro@xxxxxxxxxxxxx> > TO: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> > CC: dri-devel@xxxxxxxxxxxxxxxxxxxxx, Daniel Vetter <daniel.vetter@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, Yannick Fertre <yannick.fertre@xxxxxx>, Philippe Cornu <philippe.cornu@xxxxxx>, David Airlie <airlied@xxxxxxxx> > CC: linux-kernel@xxxxxxxxxxxxxxx, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, Yannick Fertre <yannick.fertre@xxxxxx>, Philippe Cornu <philippe.cornu@xxxxxx>, David Airlie <airlied@xxxxxxxx> > > Hi Masahiro, > > [auto build test WARNING on drm/drm-next] > [cannot apply to v4.12-rc1 next-20170518] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Masahiro-Yamada/drm-stm-add-COMPILE_TEST-to-Kconfig/20170519-131342 > base: git://people.freedesktop.org/~airlied/linux.git drm-next > :::::: branch date: 3 hours ago > :::::: commit date: 3 hours ago > >>> drivers/gpu/drm/stm/ltdc.c:466:7-15: duplicated argument to & or | > > git remote add linux-review https://github.com/0day-ci/linux > git remote update linux-review > git checkout c669a25d907f95d3e13f1dae9812642330b4aa28 > vim +466 drivers/gpu/drm/stm/ltdc.c > > b759012c Yannick Fertre 2017-04-14 450 accum_vbp = vsync + vm.vback_porch; > b759012c Yannick Fertre 2017-04-14 451 accum_act_w = accum_hbp + vm.hactive; > b759012c Yannick Fertre 2017-04-14 452 accum_act_h = accum_vbp + vm.vactive; > b759012c Yannick Fertre 2017-04-14 453 total_width = accum_act_w + vm.hfront_porch; > b759012c Yannick Fertre 2017-04-14 454 total_height = accum_act_h + vm.vfront_porch; > b759012c Yannick Fertre 2017-04-14 455 > b759012c Yannick Fertre 2017-04-14 456 clk_disable(ldev->pixel_clk); > b759012c Yannick Fertre 2017-04-14 457 > b759012c Yannick Fertre 2017-04-14 458 if (clk_set_rate(ldev->pixel_clk, rate) < 0) { > b759012c Yannick Fertre 2017-04-14 459 DRM_ERROR("Cannot set rate (%dHz) for pixel clk\n", rate); > b759012c Yannick Fertre 2017-04-14 460 return; > b759012c Yannick Fertre 2017-04-14 461 } > b759012c Yannick Fertre 2017-04-14 462 > b759012c Yannick Fertre 2017-04-14 463 clk_enable(ldev->pixel_clk); > b759012c Yannick Fertre 2017-04-14 464 > b759012c Yannick Fertre 2017-04-14 465 /* Configures the HS, VS, DE and PC polarities. */ > b759012c Yannick Fertre 2017-04-14 @466 val = HSPOL_AL | HSPOL_AL | DEPOL_AL | PCPOL_IPC; Thanks Julia for your comments. Masahiro, may I ask you please to propose a patch (simply rename the 2nd HSPOL_AL to VSPOL_AL at line 466.) as the issue is revealed by your patch named "drm/stm: add COMPILE_TEST to Kconfig". Many thanks, Philippe > b759012c Yannick Fertre 2017-04-14 467 > b759012c Yannick Fertre 2017-04-14 468 if (vm.flags & DISPLAY_FLAGS_HSYNC_HIGH) > b759012c Yannick Fertre 2017-04-14 469 val |= HSPOL_AH; > b759012c Yannick Fertre 2017-04-14 470 > b759012c Yannick Fertre 2017-04-14 471 if (vm.flags & DISPLAY_FLAGS_VSYNC_HIGH) > b759012c Yannick Fertre 2017-04-14 472 val |= VSPOL_AH; > b759012c Yannick Fertre 2017-04-14 473 > b759012c Yannick Fertre 2017-04-14 474 if (vm.flags & DISPLAY_FLAGS_DE_HIGH) > > :::::: The code at line 466 was first introduced by commit > :::::: b759012c5fa761ee08998c80fc4ad6343c258487 drm/stm: Add STM32 LTDC driver > > :::::: TO: Yannick Fertre <yannick.fertre@xxxxxx> > :::::: CC: Eric Anholt <eric@xxxxxxxxxx> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
