Hi Emil,
I didn't modify the code. I'm using Ubuntu 14.04 gcc 4.8.4, the configure pass but
fail when compile.
I think my gcc support c99 but needs adding "-std=c99" to enable it, and the configure
script add it into CC variable. When just use "make", it's OK, but my build script uses
"make CC=gcc".
If you think current state is OK, I can change my build script for that.
Regards,
Qiang
________________________________________
From: Emil Velikov <emil.l.velikov@xxxxxxxxx>
Sent: Wednesday, May 17, 2017 9:17:53 PM
To: Yu, Qiang
Cc: ML dri-devel
Subject: Re: [PATCH libdrm] xf86drm: fix compile error for declare i in for loop
Hi Qiang Yu,
On 17 May 2017 at 10:26, Qiang Yu <Qiang.Yu@xxxxxxx> wrote:
> error log:
> xf86drm.c: In function 'parse_separate_sysfs_files':
> xf86drm.c:3104:5: error: 'for' loop initial declarations are only allowed in C99 mode
> for (unsigned i = ignore_revision ? 1 : 0; i < ARRAY_SIZE(attrs); i++) {
> ^
> xf86drm.c:3104:5: note: use option -std=c99 or -std=gnu99 to compile your code
> make[4]: *** [libdrm_la-xf86drm.lo] Error 1
>
configure should error out if the compiler does not support C99. Are
you explicitly patching that out?
Why can't we use a C99 in 2017 - gcc and clang has supported it for 10+ years.
Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
