Hi Tomi,
Thank you for the patch.
On Friday 12 May 2017 13:41:36 Tomi Valkeinen wrote:
> recommended_bpp hasn't been used for ages, remove the code.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 1 -
> drivers/gpu/drm/omapdrm/dss/display.c | 33 ---------------------
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 2 --
> 3 files changed, 36 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c index
> ac5800c72cb4..1fbbe4c4bce6 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> @@ -1117,7 +1117,6 @@ static struct omap_dss_driver dsicm_ops = {
> .sync = dsicm_sync,
>
> .get_resolution = dsicm_get_resolution,
> - .get_recommended_bpp = omapdss_default_get_recommended_bpp,
>
> .enable_te = dsicm_enable_te,
> .get_te = dsicm_get_te,
> diff --git a/drivers/gpu/drm/omapdrm/dss/display.c
> b/drivers/gpu/drm/omapdrm/dss/display.c index ac2e297e7e1b..10c36539d8ee
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/display.c
> +++ b/drivers/gpu/drm/omapdrm/dss/display.c
> @@ -38,37 +38,6 @@ void omapdss_default_get_resolution(struct
> omap_dss_device *dssdev, }
> EXPORT_SYMBOL(omapdss_default_get_resolution);
>
> -int omapdss_default_get_recommended_bpp(struct omap_dss_device *dssdev)
> -{
> - switch (dssdev->type) {
> - case OMAP_DISPLAY_TYPE_DPI:
> - if (dssdev->phy.dpi.data_lines == 24)
> - return 24;
> - else
> - return 16;
> -
> - case OMAP_DISPLAY_TYPE_DBI:
> - if (dssdev->ctrl.pixel_size == 24)
> - return 24;
> - else
> - return 16;
> - case OMAP_DISPLAY_TYPE_DSI:
> - if (dssdev->panel.dsi_pix_fmt == OMAP_DSS_DSI_FMT_RGB565)
> - return 16;
> - else
> - return 24;
> - case OMAP_DISPLAY_TYPE_VENC:
> - case OMAP_DISPLAY_TYPE_SDI:
> - case OMAP_DISPLAY_TYPE_HDMI:
> - case OMAP_DISPLAY_TYPE_DVI:
> - return 24;
> - default:
> - BUG();
> - return 0;
> - }
> -}
> -EXPORT_SYMBOL(omapdss_default_get_recommended_bpp);
> -
> void omapdss_default_get_timings(struct omap_dss_device *dssdev,
> struct videomode *vm)
> {
> @@ -104,8 +73,6 @@ int omapdss_register_display(struct omap_dss_device
> *dssdev)
>
> if (drv && drv->get_resolution == NULL)
> drv->get_resolution = omapdss_default_get_resolution;
> - if (drv && drv->get_recommended_bpp == NULL)
> - drv->get_recommended_bpp =
omapdss_default_get_recommended_bpp;
> if (drv && drv->get_timings == NULL)
> drv->get_timings = omapdss_default_get_timings;
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> b/drivers/gpu/drm/omapdrm/dss/omapdss.h index abdb332019e9..47f0205809a1
> 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -730,7 +730,6 @@ struct omap_dss_driver {
> u16 *xres, u16 *yres);
> void (*get_dimensions)(struct omap_dss_device *dssdev,
> u32 *width, u32 *height);
> - int (*get_recommended_bpp)(struct omap_dss_device *dssdev);
>
> int (*check_timings)(struct omap_dss_device *dssdev,
> struct videomode *vm);
> @@ -792,7 +791,6 @@ struct omap_overlay_manager
> *omapdss_find_mgr_from_display(struct omap_dss_devic
>
> void omapdss_default_get_resolution(struct omap_dss_device *dssdev,
> u16 *xres, u16 *yres);
> -int omapdss_default_get_recommended_bpp(struct omap_dss_device *dssdev);
> void omapdss_default_get_timings(struct omap_dss_device *dssdev,
> struct videomode *vm);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
