On 08/05/17 14:32, Laurent Pinchart wrote: > Both structures describe features of a particular OMAP DSS version, > there's no reason to keep them separate. Merge them together, allowing > initialization of the features based on the DSS compatible string > instead of the OMAP SoC version. I don't think this is the correct way. As I mentioned earlier, dss_features should go. We should work on moving the parts from dss_features to each individual driver. I think there are probably only a very few dss-features that need to be accessed by multiple files, and those features could have a function of their own to query them. But that may also be a bit bigger work, so... I thought about it already earlier in this series: wouldn't it be easier to first reconstruct the current OMAPDSS_VER_* with soc_device_match(), at module init time, which would allow us to keep most of the omapdss side unchanged. Then continue removing the arch/arm/ stuff. When that's done and merged, we could have follow up patches later to clean up dss_features, and add version handling to each driver, however is best in that particular file. I feel that this series is perhaps doing a bit too much at once. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
