On 08/05/17 14:32, Laurent Pinchart wrote: > The HDMI PHY features are dependent on the HDMI transmitter model. The > PHY driver contains features for all supported transmitters, and selects > the appropriate features based on the OMAP SoC version. > > It makes more sense to store the features in the HDMI transmitter > drivers and pass them to the HDMI PHY initialization function, as the > HDMI transmitter drivers are transmitter-specific and don't need to > check the OMAP SoC version. I don't think this is correct. PHY and HDMI are separate components, you could swap the PHY. In theory, at least. While the PHY .c is not a separate driver, I still like that it contains information about the PHY hardware versions which it supports, like a real driver would. The same applies to the next patch, the PLL is not part of HDMI. In the third patch you pass 4 or 5 to the WP code as a version. So maybe rather create an HDMI_VERSION (or something) enum, which can be passed to phy, pll and wp? Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
