Re: [PATCH v2 05/28] drm: omapdrm: Infer the OMAP version from the SoC family

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/05/17 14:32, Laurent Pinchart wrote:
> The omapdrm exposes the SoC version to userspace through an integer that
> contains the OMAP model (e.g. 0x3430 for the OMAP3430). This is an
> unfortunate choice of userspace API as it's both conceptually wrong
> (userspace nowadays should use /sys/bus/soc/ for that purpose) and
> inaccurate as many models with different features are reported with the
> same version number.
> 
> The only known user of this API is the xomap X11 driver. Even if it has
> been deprecated for some time we can't drop the kernel API yet. We can,
> however, infer the version number from the SoC family to avoid the need
> to pass the version number through platform data.
> 
> Do this, which makes the omapdrm platform data not needed anymore, and
> ready to be removed.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/omapdrm/omap_drv.c | 14 ++++++++++++--
>  drivers/gpu/drm/omapdrm/omap_drv.h |  1 -
>  2 files changed, 12 insertions(+), 3 deletions(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux