On 08/05/17 16:55, Laurent Pinchart wrote: > Hi Tomi, > > On Monday 08 May 2017 15:52:07 Tomi Valkeinen wrote: >> On 08/05/17 14:32, Laurent Pinchart wrote: >>> The devm_ioremap_resource() call can handle being given a NULL resource, >>> and prints an error message when mapping fails. Switch the remaining >>> devm_ioremap() calls to devm_ioremap_resource() and remove all >>> extraneous resource NULL checks and error messages printed manually by >>> the driver. >> >> Looks like in some places we check for "!ret" and in some "IS_ERR(ret)"... > > Oops :-/ > > From 94d2a8f445cd298d99ffc4717d2184dcf21e8889 Mon Sep 17 00:00:00 2001 > From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Date: Sun, 7 May 2017 00:29:09 +0300 > Subject: [PATCH v2.1 01/28] drm: omapdrm: Remove duplicate error messages when mapping memory > > The devm_ioremap_resource() call can handle being given a NULL resource, > and prints an error message when mapping fails. Switch the remaining > devm_ioremap() calls to devm_ioremap_resource() and remove all > extraneous resource NULL checks and error messages printed manually by > the driver. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Changes since v2: > > - Fix devm_ioremap_resource() return value checks Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
