On 4 May 2017 at 17:39, Adam Jackson <ajax@xxxxxxxxxx> wrote: > AC_HEADER_MAJOR only defines MAJOR_IN_SYSMACROS if major() is _not_ > defined by <sys/types.h> alone. It is, but it warns, and that's ugly. > To fix this, push -Werror into CFLAGS when invoking AC_HEADER_MAJOR so > the warning makes the compilation test fail. > > Signed-off-by: Adam Jackson <ajax@xxxxxxxxxx> > --- > configure.ac | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/configure.ac b/configure.ac > index e5158b7d..43fcf68f 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -54,7 +54,11 @@ AC_USE_SYSTEM_EXTENSIONS > AC_SYS_LARGEFILE > AC_FUNC_ALLOCA > > +save_CFLAGS="$CFLAGS" > +export CFLAGS="$CFLAGS -Werror" > AC_HEADER_MAJOR > +CFLAGS="$save_CFLAGS" > + IIRC the Sun compiler supports (albeit undocumented) Werror if anyone is using it. So this should be fine. Reviewed-by: Emil Velikov <emil.velilkov@xxxxxxxxxxxxx> -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
