Hi Tomi, On Monday 24 Apr 2017 12:37:24 Tomi Valkeinen wrote: > On 15/04/17 12:16, Laurent Pinchart wrote: > > Create a standard zpos property for every plane as an alias to the > > omapdrm-specific zorder property. Unlike the zorder property that has to > > be instantiated for both planes and CRTCs due to backward compatibility, > > the zpos property is only instantiated for planes. When userspace will > > have switched to the zpos property the zorder property will be removed. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > > > drivers/gpu/drm/omapdrm/omap_plane.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c > > b/drivers/gpu/drm/omapdrm/omap_plane.c index 521dd2ea519a..871a89b87e72 > > 100644 > > --- a/drivers/gpu/drm/omapdrm/omap_plane.c > > +++ b/drivers/gpu/drm/omapdrm/omap_plane.c > > @@ -324,6 +324,7 @@ struct drm_plane *omap_plane_init(struct drm_device > > *dev,> > > drm_plane_helper_add(plane, &omap_plane_helper_funcs); > > > > omap_plane_install_properties(plane, &plane->base); > > > > + drm_plane_create_zpos_property(plane, 0, 0, 3); > > I think this should use get_num_ovls() to get the max value. That's fine with me, but note that the code currently hardcodes the value to 3 for the zorder property. I can submit an addition patch on top of this to change both if you think it would be better. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
