On Wed 12 Apr 14:15 PDT 2017, Jordan Crouse wrote: > Simply the code use snprintf correctly and make sure that we memset > the rest of the segment if the memory size in the ELF file is larger > than the file size. > > Signed-off-by: Jordan Crouse <jcrouse@xxxxxxxxxxxxxx> Please squash this with the prior commits. > --- > drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 70 +++++++++++++++++------------------ > 1 file changed, 35 insertions(+), 35 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c [..] > @@ -151,9 +150,9 @@ static int _pil_tz_load_image(struct platform_device *pdev) > fw_size = (size_t) (fw_max_addr - fw_min_addr); > > /* Verify the MDT header */ > - ret = qcom_scm_pas_init_image(pas_id, mdt->data, mdt->size); > + ret = qcom_scm_pas_init_image(13, mdt->data, mdt->size); Please turn 13 into a define. > if (ret) { > - dev_err(&pdev->dev, "Invalid firmware metadata\n"); > + DRM_DEV_ERROR(&pdev->dev, "Invalid firmware metadata\n"); > goto out; > } > Regards, Bjorn _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel