On Mon, Apr 17, 2017 at 11:42:18PM +0800, Alex Deucher wrote: > On Mon, Apr 17, 2017 at 3:38 AM, Huang Rui <ray.huang@xxxxxxx> wrote: > > The ret must be 0 here, otherwise, the function will return after > init_mem_type. > > > > Signed-off-by: Huang Rui <ray.huang@xxxxxxx> > > I think you can drop the initial assignment of ret as well. Either way: > > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > Yep, we needn't set ret as EINVAL at first, because it must be assigned before return. Thanks, Rui _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
