Sean Paul <seanpaul@xxxxxxxxxxxx> writes: > On Mon, Apr 17, 2017 at 09:26:03AM -0700, Eric Anholt wrote: >> We were returning without decrementing if the error happened, meaning >> that at the next submit we wouldn't try to bring up the power domain. >> >> Signed-off-by: Eric Anholt <eric@xxxxxxxxxx> > > This change looks good to me. It seems a little odd to wrap pm_runtime which > is already refcounted in another refcount, but I'm really not familiar with > the driver, and I'm sure there's a good reason for it. > > Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx> Yeah, it's an unfortunate hack because the reset control is buried in the power domain driver on the RPi, so we have to get the power domain actually off (0 refcount) in order to reset the GPU. Yay for building around closed-source firmware :(
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
