On 04/13/2017 01:22 AM, Alastair Bridgewater wrote:
On Tue, Apr 11, 2017 at 1:32 PM, Ilia Mirkin <imirkin@xxxxxxxxxxxx
<mailto:imirkin@xxxxxxxxxxxx>> wrote:
On Tue, Apr 11, 2017 at 1:11 PM, Alastair Bridgewater
<alastair.bridgewater@xxxxxxxxx
<mailto:alastair.bridgewater@xxxxxxxxx>> wrote:
> + /* HDMI 3D support */
> + if ((disp->disp.oclass >= NV50_DISP)
You probably meant G82_DISP. Although I don't know if there were any
G80's with DP or HDMI. Either way, all that logic is in hdmig84.c (and
newer), so ... :)
Having taken a closer look at the lower level code, I agree. It should
be G82_DISP. Will correct in the v4 patch series (if there ends up
being a v4 patch series). Good catch, and thank you!
Hey Alastair,
Firstly, a minor nit-pick: I modified some of the commit titles a
little. For any changes under nvkm/, use
"drm/nouveau/[SUBDEV][/CHIPSET(s)]:" as a prefix instead of just
drm/nouveau.
Second, and more importantly, this series looks really good to me. Nice
work!
I've given it a quick test on a 3D-capable TV I have, and the TV
definitely thinks it's getting a 3D mode :) My glasses are flat, so
couldn't test any further.
Regardless, I've fixed up the suggestion that Ilia made and merged the
series.
If there's any other changes to come, there's plenty of time to squash
those in before the next merge window.
Thanks again,
Ben.
-- Alastair Bridgewater
_______________________________________________
Nouveau mailing list
Nouveau@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
