Re: [PATCH libdrm] configure.ac: pthread-stubs is not a thing on GNU/kFreeBSD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2017-04-05 18:43 GMT+02:00 Eric Engestrom <eric.engestrom@xxxxxxxxxx>:
> On Wednesday, 2017-04-05 17:24:31 +0100, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
>>
>> As mentioned on the xcb mailing list, the platform uses the GLIBC
>> forwarding mechanism.
>>
>> https://lists.freedesktop.org/archives/xcb/2016-November/010896.html
>>
>> Cc: Andreas Boll <andreas.boll.dev@xxxxxxxxx>
>> Reported-by: Andreas Boll <andreas.boll.dev@xxxxxxxxx>
>> Signed-off-by: Emil Velikov <emil.velikov@xxxxxxxxxxxxx>
>> ---
>> I'm slightly inclined to go a single *gnu* but I'm not 100% sure if that
>> won't catch some corner case platforms. Opinions ?
>
> Go with `*gnu*` and replace it with something more complex if/when
> someone reports this breaks their platform?
> Without knowing any more, it's almost as likely that this hypothetical
> platform would match `*-gnu*` as well anyway.
>
> Either way:
> Reviewed-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>

Yeah, sounds good.

Either way too for this and the mesa patch:
Reviewed-by: Andreas Boll <andreas.boll.dev@xxxxxxxxx>

>
>> ---
>>  configure.ac | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index f1a13090..0f6fe46d 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -64,7 +64,7 @@ LT_INIT([disable-static])
>>  dnl pthread-stubs is mandatory on BSD platforms, due to the nature of the
>>  dnl project. Even then there's a notable issue as described in the project README
>>  case "$host_os" in
>> -linux* | cygwin* | darwin* | solaris* | gnu*)
>> +linux* | cygwin* | darwin* | solaris* | *-gnu* | gnu*)
>>      pthread_stubs_possible="no"
>>      ;;
>>  * )
>> --
>> 2.11.1
>>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux