Re: [PATCH 1/4] drm: zte: do not enable clock auto-gating by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 21, 2017 at 08:15:53PM +0800, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@xxxxxxxxxx>
> 
> Some VOU modules do not work well with clock auto-gating.  For example,
> VGA I2C bus will fail to read EDID data from monitor.  Let's not enable
> this feature by default, and leave it to the possible future low-power
> optimization.
> 

Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>

> Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/zte/zx_vou.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/zte/zx_vou.c b/drivers/gpu/drm/zte/zx_vou.c
> index cf92d675feaa..2a2d90bd9425 100644
> --- a/drivers/gpu/drm/zte/zx_vou.c
> +++ b/drivers/gpu/drm/zte/zx_vou.c
> @@ -720,9 +720,6 @@ static void vou_hw_init(struct zx_vou_hw *vou)
>  	/* Release reset for all VOU modules */
>  	zx_writel(vou->vouctl + VOU_SOFT_RST, ~0);
>  
> -	/* Enable clock auto-gating for all VOU modules */
> -	zx_writel(vou->vouctl + VOU_CLK_REQEN, ~0);
> -
>  	/* Enable all VOU module clocks */
>  	zx_writel(vou->vouctl + VOU_CLK_EN, ~0);
>  
> -- 
> 1.9.1

-- 
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux