Re: [PATCH libdrm 2/2] tegra: update symbol-check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 3, 2017 at 6:59 PM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote:
> On 29 March 2017 at 23:24, Erik Faye-Lund <kusmabite@xxxxxxxxx> wrote:
>> I get a few more symbols in my build tegra-libraries, so let's
>> include these in the whitelist as well.
>>
>> While we're at it, update the comment at the top.
>>
>> Signed-off-by: Erik Faye-Lund <kusmabite@xxxxxxxxx>
> R-B and pushed to master.
>
> Out of curiosity:
> What platform are you using that introduces these - musl, newer glibc, other ?

I'm using glibc 2.25 (in particular, 2.25-1 from Arch Linux).

> Would be great if we can strip platform specific symbols from the list
> - do you have any ideas how we can do that ?
> We could omit any symbols that start with __ but that does not sound too robust.

I think ignoring anything that starts with both single and double
underscore would make sense, as those symbols are reserved by the
compiler and "implementation" (typically libc etc). Our API shouldn't
export these symbols in the first place, and I suspect code-review is
sufficient to ensure this.

But either way, I'd prefer to just get the test working again first.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux