On 2017-03-27 15:17:54, Sinclair Yeh wrote:
> From: Øyvind A. Holm <sunny@xxxxxxxxxxx>
>
> This reverts commit 2d8e60e8b074 ("drm/vmwgfx: Replace numeric
> parameter like 0444 with macro")
> [...]
> index 45d711e..d31dc34 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -241,13 +241,13 @@ static int vmwgfx_pm_notifier(struct notifier_block *nb, unsigned long val,
> void *ptr);
>
> MODULE_PARM_DESC(enable_fbdev, "Enable vmwgfx fbdev");
> -module_param_named(enable_fbdev, enable_fbdev, int, S_IRUSR | S_IWUSR);
> +module_param_named(enable_fbdev, enable_fbdev, int, 0600);
> MODULE_PARM_DESC(force_dma_api, "Force using the DMA API for TTM pages");
> -module_param_named(force_dma_api, vmw_force_iommu, int, S_IRUSR | S_IWUSR);
> +module_param_named(force_dma_api, vmw_force_iommu, int, 0600);
> MODULE_PARM_DESC(restrict_iommu, "Try to limit IOMMU usage for TTM pages");
> -module_param_named(restrict_iommu, vmw_restrict_iommu, int, S_IRUSR | S_IWUSR);
> +module_param_named(restrict_iommu, vmw_restrict_iommu, int, 0600);
> MODULE_PARM_DESC(force_coherent, "Force coherent TTM pages");
> -module_param_named(force_coherent, vmw_force_coherent, int, S_IRUSR | S_IWUSR);
> +module_param_named(force_coherent, vmw_force_coherent, int, 0600);
> MODULE_PARM_DESC(restrict_dma_mask, "Restrict DMA mask to 44 bits with IOMMU");
> module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, S_IRUSR | S_IWUSR);
> MODULE_PARM_DESC(assume_16bpp, "Assume 16-bpp when filtering modes");
> --
> 2.7.4
It seems as something has happened to the patch when applied, the last
change is gone, it was in my original patch sent to the list. This
change is missing:
-module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, S_IRUSR | S_IWUSR);
+module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, 0600);
I suppose it's to late to fix this exact commit (50f837371dd9) now
because it's part of the request-pull mail sent 2017-03-31 16:32:55
-0700. I can send a new patch created on top of commit 28c954299cd2
("drm/vmwgfx: Properly check display/scanout surface size") that
completes this patch, if it's ok.
Regards,
Øyvind
+-| Øyvind A. Holm <sunny@xxxxxxxxxxx> - N 60.37604° E 5.33339° |-+
| OpenPGP: 0xFB0CBEE894A506E5 - http://www.sunbase.org/pubkey.asc |
| Fingerprint: A006 05D6 E676 B319 55E2 E77E FB0C BEE8 94A5 06E5 |
+------------| 32db7b80-176e-11e7-8de9-db5caa6d21d3 |-------------+
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
