Re: [PATCH libdrm 2/3] exynos/fimg2d: remove unused-function build warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Seung-Woo,

looks good to me. Also, g2d_reset() never worked in the first place,
since the kernel driver rejects writes to SOFT_RESET_REG.

Reviewed-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>

With best wishes,
Tobias


Seung-Woo Kim wrote:
> The function g2d_reset() is not anymore used after the commit
> e3c97d1a2473 ("exynos/fimg2d: add g2d_validate_xyz() functions"),
> so it should be removed.
> 
> Signed-off-by: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>
> ---
>  exynos/exynos_fimg2d.c |   14 --------------
>  1 files changed, 0 insertions(+), 14 deletions(-)
> 
> diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c
> index 7f1d105..61340c3 100644
> --- a/exynos/exynos_fimg2d.c
> +++ b/exynos/exynos_fimg2d.c
> @@ -293,20 +293,6 @@ static void g2d_set_direction(struct g2d_context *ctx,
>  }
>  
>  /*
> - * g2d_reset - reset fimg2d hardware.
> - *
> - * @ctx: a pointer to g2d_context structure.
> - *
> - */
> -static void g2d_reset(struct g2d_context *ctx)
> -{
> -	ctx->cmd_nr = 0;
> -	ctx->cmd_buf_nr = 0;
> -
> -	g2d_add_cmd(ctx, SOFT_RESET_REG, 0x01);
> -}
> -
> -/*
>   * g2d_flush - submit all commands and values in user side command buffer
>   *		to command queue aware of fimg2d dma.
>   *
> 

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux