Re: [PATCH v4 00/11] drm/fb-helper: Deferred setup support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thierry,

On 29.03.2017 16:43, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> This set of patches adds support for deferring FB helper setup, which is
> useful to obtain a sane configuration even when no outputs are available
> during probe.
>
> One example is HDMI, where fbdev will currently fallback to a 1024x786
> resolution if no monitor is connected, and will then forever stay that
> way. With these patches, the FB helpers will take note that it doesn't
> make sense to setup fbdev yet and will defer until a monitor is
> connected, at which point the preferred mode will be selected.

I have tested it on Exynos (TM2), generally it works but I have observed
two things:
1. Now fbdev appears on only one connected device (in my case, only on
DSI/Panel, not on HDMI/MHL/TV), I do not know if this change is intended
but I have not seen it in commit message.
2. "echo off >/sys/class/drm/card0-*/status" does not work anymore, ie
it succeeds, subsequent calls to modetest shows that connector is
disabled, but panel/TV still displays the image.

Regards
Andrzej

>
> Thierry
>
> Changes in v4:
> - use fb_conn for variables of type struct drm_fb_helper_connector *
>   for consistency
> - make top-level FB helper lock more robust
> - improve kerneldoc
>
> Changes in v3:
> - fix kerneldoc for top-level FB helper lock
> - drop some patches that no longer apply
> - add Tested-by from John Stultz
> - add cleanup patches
>
> Changes in v2:
> - now with locking
>
> Thierry Reding (11):
>   drm/fb-helper: Cleanup checkpatch warnings
>   drm/fb-helper: Reshuffle code for subsequent patches
>   drm/fb-helper: Improve code readability
>   drm/fb-helper: Push down modeset lock into FB helpers
>   drm/fb-helper: Add top-level lock
>   drm/fb-helper: Make top-level lock more robust
>   drm/fb-helper: Support deferred setup
>   drm/exynos: Remove custom FB helper deferred setup
>   drm/hisilicon: Remove custom FB helper deferred setup
>   drm/atmel-hlcdc: Remove unnecessary NULL check
>   drm/rockchip: Remove unnecessary NULL check
>
>  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c    |   3 +-
>  drivers/gpu/drm/drm_fb_helper.c                 | 376 +++++++++++++++++-------
>  drivers/gpu/drm/exynos/exynos_drm_drv.c         |   6 +-
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c       |  23 --
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c |  21 +-
>  drivers/gpu/drm/i915/intel_dp_mst.c             |   3 -
>  drivers/gpu/drm/radeon/radeon_dp_mst.c          |   7 -
>  drivers/gpu/drm/rockchip/rockchip_drm_fb.c      |   4 +-
>  include/drm/drm_fb_helper.h                     |  35 +++
>  9 files changed, 316 insertions(+), 162 deletions(-)
>

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux