Re: [PATCHv3 27/30] drm/omap: dispc: improve debug print of display flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29/03/17 12:00, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Tuesday 28 Mar 2017 16:08:13 Tomi Valkeinen wrote:
>> Instead of printing 0/1 for display flags like vsync high/low, use a
>> tri-state print (-1/0/1) to indicate the "undefined" state.
> 
> Even better would be to use high/low/unknown (or H/L/U or any similar set of 
> values).

Hmm I don't know... high/low/unknown would make the debug print much
longer, whereas H/L/U doesn't mean anything unless you check it from the
driver code. Well, probably -1/0/1 is not exactly clear either, but it's
the shortest and clearest option I have in mind.

 Tomi

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux