Hi Tomi, Thank you for the patch. On Tuesday 28 Mar 2017 16:08:15 Tomi Valkeinen wrote: > Use drm_atomic_helper_shutdown() to ensure that all crtcs are disabled > when unloading the driver. > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > Cc: Daniel Vetter <daniel@xxxxxxxx> > > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c > b/drivers/gpu/drm/omapdrm/omap_drv.c index ad8d16cf819c..7b917c0c1a27 > 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -865,6 +865,8 @@ static int pdev_remove(struct platform_device *pdev) > if (priv->fbdev) > omap_fbdev_free(ddev); > > + drm_atomic_helper_shutdown(ddev); > + Can the hardware still be enabled at this point ? If pdev_remove() is called we shouldn't have any application holding the device open (otherwise we'll crash miserably), and the fbdev compatibility layer is disabled on the previous line. > drm_mode_config_cleanup(ddev); > > omap_drm_irq_uninstall(ddev); -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
