Re: [PATCH] drm: mali-dp: remove unused variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 28, 2017 at 04:07:58PM +0200, Arnd Bergmann wrote:
> The newly introduced function causes a harmless build warning:
> 
> drivers/gpu/drm/arm/malidp_planes.c: In function 'malidp_plane_atomic_print_state':
> drivers/gpu/drm/arm/malidp_planes.c:98:23: error: unused variable 'mp' [-Werror=unused-variable]
> 
> The variable serves no purpose here and can be removed.

Ouch, shame on me for not noticing it :(

Thanks for this!

Acked-by: Liviu Dudau <Liviu.Dudau@xxxxxxx>

> 
> Fixes: 242f43b69c61 ("drm: mali-dp: add atomic_print_state for planes")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  drivers/gpu/drm/arm/malidp_planes.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 5b0bad87f0b5..afd59e0f7918 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -95,7 +95,6 @@ static void malidp_plane_atomic_print_state(struct drm_printer *p,
>  					    const struct drm_plane_state *state)
>  {
>  	struct malidp_plane_state *ms = to_malidp_plane_state(state);
> -	struct malidp_plane *mp = to_malidp_plane(state->plane);
>  
>  	drm_printf(p, "\trotmem_size=%u\n", ms->rotmem_size);
>  	drm_printf(p, "\tformat_id=%u\n", ms->format);
> -- 
> 2.9.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux