Re: [PATCH 00/11] Enable Atomic Mode Set on vmwgfx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 27, 2017 at 03:00:53PM -0700, Sinclair Yeh wrote:
> This series enables atomic mode set on vmwgfx.  Developed in
> collaboration with Thomas Hellstrom and the VMWare Graphics
> Team.

Yay!

I've given it a quick read-thru and sprinkled some comments over a bunch
of places. One top-level suggestion would be to review all the hooks you
have and vmw-specific callbacks and make sure you really need them all. A
bunch can definitely be removed after the transition, and in general we've
tried really hard to make the atomic helpers not get in the way so much
and require pointless boilerplate.

I haven't seen them, but I assume you have suspend/resume and stuff like
that too. Might be good to look into the suspend/resume/shutdown helpers
we now have in drm-misc.

On the series, with my comments addressed or ignored to your judgment:

Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux