Re: [RFC PATCH 1/3] drm/panel: Pull common panel code out into helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sean,

Something small that stood out while skimming through the design.

On 16 March 2017 at 22:08, Sean Paul <seanpaul@xxxxxxxxxxxx> wrote:

>  struct panel_simple {
>         struct drm_panel base;
> +       struct panel_common common;
> +
>         bool prepared;
>         bool enabled;
>
There two should go ?

>         const struct panel_desc *desc;
>
> -       struct backlight_device *backlight;
> -       struct regulator *supply;
>         struct i2c_adapter *ddc;
>
>         struct gpio_desc *enable_gpio;
This should go as well ?

Regards,
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux