On Thu, Mar 23, 2017 at 06:54:52PM +0000, Jose Abreu wrote: > Hi Ville, > > > On 23-03-2017 15:16, Ville Syrjälä wrote: > > On Wed, Mar 22, 2017 at 05:35:58PM +0000, Jose Abreu wrote: > >> Add the HDMI 2.0 aspect ratio flags (64:27 and 256:135) and a new > >> flag which will signal userspace that this is a HDMI 2.0+ mode. It > >> is expected that these new flags will not be exported to userspace > >> unless client asks to. > > W.r.t. the aspect ratio userspace story, there was some discussion > > on #dri-devel recently about extending the xrandr protocol for 3d stereo > > support. If that is going to happen then it might make sense to try > > and get the aspect ratio stuff also included at the same time so > > that we would only have to deal with one protocol bump. > > Hmm, are you saying to just use one knob for 3d and the aspect > ratios? No. I'm saying that extending xrandr with either means a protocol bump. But if we do both at the same time we just need one bump. > Aren't there already userspace consumers of the 3d knob? Not that I know of. And there's definitely nothing in xrandr for this stuff, so any consumer would have to be something non-x11 based. > > Best regards, > Jose Miguel Abreu > > > > >> Signed-off-by: Jose Abreu <joabreu@xxxxxxxxxxxx> > >> Cc: Carlos Palminha <palminha@xxxxxxxxxxxx> > >> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > >> --- > >> include/uapi/drm/drm_mode.h | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h > >> index 8c67fc0..62e679c 100644 > >> --- a/include/uapi/drm/drm_mode.h > >> +++ b/include/uapi/drm/drm_mode.h > >> @@ -89,6 +89,8 @@ > >> #define DRM_MODE_PICTURE_ASPECT_NONE 0 > >> #define DRM_MODE_PICTURE_ASPECT_4_3 1 > >> #define DRM_MODE_PICTURE_ASPECT_16_9 2 > >> +#define DRM_MODE_PICTURE_ASPECT_64_27 3 > >> +#define DRM_MODE_PICTURE_ASPECT_256_135 4 > >> > >> /* Aspect ratio flag bitmask (4 bits 22:19) */ > >> #define DRM_MODE_FLAG_PIC_AR_MASK (0x0F<<19) > >> @@ -98,6 +100,13 @@ > >> (DRM_MODE_PICTURE_ASPECT_4_3<<19) > >> #define DRM_MODE_FLAG_PIC_AR_16_9 \ > >> (DRM_MODE_PICTURE_ASPECT_16_9<<19) > >> +#define DRM_MODE_FLAG_PIC_AR_64_27 \ > >> + (DRM_MODE_PICTURE_ASPECT_64_27<<19) > >> +#define DRM_MODE_FLAG_PIC_AR_256_135 \ > >> + (DRM_MODE_PICTURE_ASPECT_256_135<<19) > >> + > >> +/* HDMI 2.0+ mode flag: will only be set if client supports it */ > >> +#define DRM_MODE_FLAG_HDMI2 (1<<23) > >> > >> /* DPMS flags */ > >> /* bit compatible with the xorg definitions. */ > >> -- > >> 1.9.1 > >> > >> > >> _______________________________________________ > >> dri-devel mailing list > >> dri-devel@xxxxxxxxxxxxxxxxxxxxx > >> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.freedesktop.org_mailman_listinfo_dri-2Ddevel&d=DwIDAw&c=DPL6_X_6JkXFx7AXWqB0tg&r=WHDsc6kcWAl4i96Vm5hJ_19IJiuxx_p_Rzo2g-uHDKw&m=BBAO8Rra0sW4KcCLB5lMOfONxg0v9pfUSaDNr5WDh2w&s=p6tAeWYwiSDL7BonKeijv2zmweBF9eW7xV7OX5e5gG4&e= -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
