On Tue, Mar 21, 2017 at 09:13:58AM +0100, Thierry Reding wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > The expression &private->fbdev_helper can never be NULL, so the check is > completely unnecessary. > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> On the 3 drivers patches (all except exynos): Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> For merging, do you want to push it all through drm-misc? Or planning on sending a pull request to Dave? -Daniel > --- > drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > index 81f9548672b0..df6bceabeca8 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c > @@ -168,10 +168,8 @@ rockchip_user_fb_create(struct drm_device *dev, struct drm_file *file_priv, > static void rockchip_drm_output_poll_changed(struct drm_device *dev) > { > struct rockchip_drm_private *private = dev->dev_private; > - struct drm_fb_helper *fb_helper = &private->fbdev_helper; > > - if (fb_helper) > - drm_fb_helper_hotplug_event(fb_helper); > + drm_fb_helper_hotplug_event(&private->fbdev_helper); > } > > static void > -- > 2.12.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel