Hi! > The N950's display requires two regulators. > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > --- > drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 55 +++++++++++++++++++++++-- > 1 file changed, 52 insertions(+), 3 deletions(-) > @@ -590,25 +594,43 @@ static int dsicm_power_on(struct panel_drv_data *ddata) > .lp_clk_max = 10000000, > }; > > + if (ddata->vpnl) { > + r = regulator_enable(ddata->vpnl); > + if (r) { > + dev_err(&ddata->pdev->dev, > + "failed to enable VPNL: %d\n", r); > + goto err0; > + } > + } Having err0 that just returns .. is quite confusing. Just return here? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel