Re: [PATCH] drm: drm_pci.h: add missing include

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 12, 2017 at 10:34:07PM -0400, Jérémy Lefaure wrote:
> The structure platform_device is used in drm_pci.h without including
> plaform_device.h so the compiler raises a warning:
> 
> In file included from drivers/gpu/drm/drm_pci.c:29:0:
> ./include/drm/drm_pci.h:76:64: warning: ‘struct platform_device’
> declared inside parameter list
>  extern int drm_platform_init(struct drm_driver *driver,
>  struct platform_device *platform_device);
>         ^
> 
> Fixes: 23ef59ef6dcc ("drm: Extract drm_pci.h")
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@xxxxxxxxxxxx>

Fixed differently by entirely removing the drm_platform_init decl, that
one is now completely gone in linux-next.

Thanks for your patch anyway.
-Daniel

> ---
>  include/drm/drm_pci.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/drm/drm_pci.h b/include/drm/drm_pci.h
> index 5081b3e..3697a41 100644
> --- a/include/drm/drm_pci.h
> +++ b/include/drm/drm_pci.h
> @@ -33,6 +33,7 @@
>  #define _DRM_PCI_H_
>  
>  #include <linux/pci.h>
> +#include <linux/platform_device.h>
>  
>  struct drm_dma_handle;
>  struct drm_device;
> -- 
> 2.1.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux