On Fri, Mar 10, 2017 at 11:21:53AM +0100, Romain Perier wrote: > Hello, > > Le 10/03/2017 à 10:46, Russell King - ARM Linux a écrit : > > On Fri, Mar 10, 2017 at 10:35:09AM +0100, Romain Perier wrote: > >> Currently, the audio sampler clock is enabled from dw_hdmi_setup() at > >> step E. and is kept enabled for later use. This clock should be enabled > >> and disabled along with the actual audio stream and not always on (that > >> is bad for PM). Futhermore, this might cause sound glitches with some > >> HDMI devices, as the CTS+N is forced to zero when the stream is disabled > >> while the audio clock is still running. > >> > >> This commit adds a parameter to hdmi_audio_enable_clk() that controls > >> when the audio sample clock must be enabled or disabled. Then, it moves > >> the call to this function into dw_hdmi_audio_enable() and > >> dw_hdmi_audio_disable(). > > How does this interact with the workaround given in my commit introducing > > these functions? (Commit b90120a96608). > > > > Setting N=0 is a work-around for iMX6, and we need the audio FIFO to be > > loaded with data prior to setting N non-zero. If disabling the audio > > clock prevents the audio FIFO being loaded, your patch will break iMX6. > > > Mhhh, the fact is I have no IMX6 devices here (only Rockchip). So > I only tested on Rockchip devices. An approach might be to introduce an > option for handling this errata, because that's platform specific and > other platforms (like Rockchip) are in conflict with this. I'd say that they _aren't_ in conflict with it - or are you saying that the I2S driver was never functionally tested as working? I also would not think that it's platform specific - remember that this is Designware IP, and it's likely that other platforms with exactly the same IP would suffer from the same problem. It's probably revision specific, but we need Synopsis' input on that. However, I do believe that your patch probably doesn't have much merit in any case: on a mode set, you enable the audio clock, and it will remain enabled until the audio device is first opened and then closed. If another mode set comes along, then exactly the same situation happens again. So, really it isn't achieving all that much. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
