Hi Sean, On Fri, Mar 10, 2017 at 1:32 PM, Sean Paul <seanpaul@xxxxxxxxxxxx> wrote: > > From: Tomasz Figa <tfiga@xxxxxxxxxxxx> > > Since we take the ownership of drvdata, the master driver does not have > any means of accessing its own data from unbind callback and all it can > do is calling the analogix unbind callback. However it might be > necessary to do some clean up in the master driver before we really > unbind the analogix part (such as PSR unregister in Rockchip case), so > this patch provides a plat_data->cleanup() callback which is called at > the beginning of analogix_dp_unbind(). > > Cc: Kristian H. Kristensen <hoegsberg@xxxxxxxxxxxx> > Cc: Brian Norris <briannorris@xxxxxxxxxxxx> > Signed-off-by: Tomasz Figa <tfiga@xxxxxxxxxxxx> > Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 3 +++ > include/drm/bridge/analogix_dp.h | 1 + > 2 files changed, 4 insertions(+) FYI, we ended up reverting this and subsequent patches from this series up to 37, as we found a simpler and cleaner solution. Please see following 2 CLs for reference: https://chromium-review.googlesource.com/442390 https://chromium-review.googlesource.com/442392 https://chromium-review.googlesource.com/442391 Anyway, thanks for sending the patches upstream, it's really helpful given my time constraints. Best regards, Tomasz _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
