On 09.03.2017 08:34, Inki Dae wrote: > Hello David, > > Thanks for report. > > 2017년 03월 06일 19:05에 David Binderman 이(가) 쓴 글: >> Hello there, >> >> linux-4.11-rc1/drivers/gpu/drm/exynos/exynos5433_drm_decon.c:681]: (warning) Result of operator '|' is always true if one operand is non-zero. Did you intend to use '&'? >> > Right. this is known issue and below patch fixes this, > http://www.spinics.net/lists/dri-devel/msg132589.html > > This patch will go to -fixes. > >> Source code is >> >> if (ctx->out_type | I80_HW_TRG) { >> >> Also in the same file: >> >> [drivers/gpu/drm/exynos/exynos5433_drm_decon.c:131]: (style) Same expression on both sides of '|'. >> >> Source code is >> >> writel(TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN >> | TRIGCON_TE_AUTO_MASK | TRIGCON_SWTRIGEN, > In this case, only problem is two flags are set in duplicate. This should be cleaned up. Thanks. :) Wrong copy/paste removed two other flags and duplicated these above. It did not hurt to much as it affects only software trigger which is not used atm. Fix sent yesterday [1]. [1]: http://www.spinics.net/lists/dri-devel/msg134877.html Regards Andrzej > >> Regards >> >> David Binderman >> >> > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
