On Wed, Mar 08, 2017 at 11:42:17AM -0300, Gustavo Padovan wrote: > Hi Philipp, > > 2017-03-08 Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>: > > > The next patch will need the dma_fence to create the sync_file in > > etnaviv_ioctl_gem_submit, in case an out_fence_fd is requested. > > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/etnaviv/etnaviv_gem.h | 3 ++- > > drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 8 +++++++- > > drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 21 ++++++--------------- > > drivers/gpu/drm/etnaviv/etnaviv_gpu.h | 1 + > > 4 files changed, 16 insertions(+), 17 deletions(-) > > > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.h b/drivers/gpu/drm/etnaviv/etnaviv_gem.h > > index 120410d67eb5b..c4a091e874269 100644 > > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.h > > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.h > > @@ -20,6 +20,7 @@ > > #include <linux/reservation.h> > > #include "etnaviv_drv.h" > > > > +struct dma_fence; > > Why not #include <linux/dma_fence.h> ? Adding needless includes when a struct prototype will do eventually creates headaches with circular dependencies and the like. Low probability in this case, but the principle is a good one to adhere to. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
