Hi Tomeu, Pardon for dropping in late. On 3 March 2017 at 13:39, Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx> wrote: > Implement the .set_crc_source() callback and call the DP helpers > accordingly to start and stop CRC capture. > > This is only done if this CRTC is currently using the eDP connector. > > v3: Remove superfluous check on rockchip_crtc_state->output_type > > v6: Remove superfluous variable > > Signed-off-by: Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx> > --- > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 41 +++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > I think this won't fly (build). Afaict analogix_dp-rockchip.c (as guarded by ROCKCHIP_ANALOGIX_DP) is the only piece that can/should have DRM_ANALOGIX_DP code. Perhaps adding a simple wrapper/stubs will be the easier option here ? -Emil _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel