Hi Laurent,
On 03-03-2017 16:50, Laurent Pinchart wrote:
> The driver is already made of 5 separate source files. Move it to a
> newly created directory named synopsys where more Synopsys bridge
> drivers can be added later (for the DisplayPort controller for
> instance).
>
> Suggested-by: Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
Thanks a lot!
There are typo errors (which were there before, I just noticed
them now), please see bellow.
Reviewed-by: Jose Abreu <joabreu@xxxxxxxxxxxx>
Best regards,
Jose Miguel Abreu
> ---
> drivers/gpu/drm/bridge/Kconfig | 2 ++
> drivers/gpu/drm/bridge/Makefile | 4 +---
> drivers/gpu/drm/bridge/synopsys/Kconfig | 23 ++++++++++++++++++++++
> drivers/gpu/drm/bridge/synopsys/Makefile | 5 +++++
> .../drm/bridge/{ => synopsys}/dw-hdmi-ahb-audio.c | 0
> .../gpu/drm/bridge/{ => synopsys}/dw-hdmi-audio.h | 0
> .../drm/bridge/{ => synopsys}/dw-hdmi-i2s-audio.c | 0
> drivers/gpu/drm/bridge/{ => synopsys}/dw-hdmi.c | 0
> drivers/gpu/drm/bridge/{ => synopsys}/dw-hdmi.h | 0
> 9 files changed, 31 insertions(+), 3 deletions(-)
> create mode 100644 drivers/gpu/drm/bridge/synopsys/Kconfig
> create mode 100644 drivers/gpu/drm/bridge/synopsys/Makefile
> rename drivers/gpu/drm/bridge/{ => synopsys}/dw-hdmi-ahb-audio.c (100%)
> rename drivers/gpu/drm/bridge/{ => synopsys}/dw-hdmi-audio.h (100%)
> rename drivers/gpu/drm/bridge/{ => synopsys}/dw-hdmi-i2s-audio.c (100%)
> rename drivers/gpu/drm/bridge/{ => synopsys}/dw-hdmi.c (100%)
> rename drivers/gpu/drm/bridge/{ => synopsys}/dw-hdmi.h (100%)
>
> Hi Jose,
>
> Here's the patch you've requested, to be applied on top of the
> "[PATCH v4 0/9] drm: bridge: dw-hdmi: Refactor PHY support" series.
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index eb8688ec6f18..68ceba083ca1 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -101,4 +101,6 @@ source "drivers/gpu/drm/bridge/analogix/Kconfig"
>
> source "drivers/gpu/drm/bridge/adv7511/Kconfig"
>
> +source "drivers/gpu/drm/bridge/synopsys/Kconfig"
> +
> endmenu
> diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
> index 2e83a7855399..103f82e63102 100644
> --- a/drivers/gpu/drm/bridge/Makefile
> +++ b/drivers/gpu/drm/bridge/Makefile
> @@ -2,9 +2,6 @@ ccflags-y := -Iinclude/drm
>
> obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) += analogix-anx78xx.o
> obj-$(CONFIG_DRM_DUMB_VGA_DAC) += dumb-vga-dac.o
> -obj-$(CONFIG_DRM_DW_HDMI) += dw-hdmi.o
> -obj-$(CONFIG_DRM_DW_HDMI_AHB_AUDIO) += dw-hdmi-ahb-audio.o
> -obj-$(CONFIG_DRM_DW_HDMI_I2S_AUDIO) += dw-hdmi-i2s-audio.o
> obj-$(CONFIG_DRM_NXP_PTN3460) += nxp-ptn3460.o
> obj-$(CONFIG_DRM_PARADE_PS8622) += parade-ps8622.o
> obj-$(CONFIG_DRM_SIL_SII8620) += sil-sii8620.o
> @@ -13,3 +10,4 @@ obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o
> obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/
> obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/
> obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o
> +obj-y += synopsys/
> diff --git a/drivers/gpu/drm/bridge/synopsys/Kconfig b/drivers/gpu/drm/bridge/synopsys/Kconfig
> new file mode 100644
> index 000000000000..4d260755f010
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/synopsys/Kconfig
> @@ -0,0 +1,23 @@
> +config DRM_DW_HDMI
> + tristate
> + select DRM_KMS_HELPER
> +
> +config DRM_DW_HDMI_AHB_AUDIO
> + tristate "Synopsis Designware AHB Audio interface"
"Synopsis" -> "Synopsys"
> + depends on DRM_DW_HDMI && SND
> + select SND_PCM
> + select SND_PCM_ELD
> + select SND_PCM_IEC958
> + help
> + Support the AHB Audio interface which is part of the Synopsis
"Synopsis" -> "Synopsys"
> + Designware HDMI block. This is used in conjunction with
> + the i.MX6 HDMI driver.
> +
> +config DRM_DW_HDMI_I2S_AUDIO
> + tristate "Synopsis Designware I2S Audio interface"
"Synopsis" -> "Synopsys"
> + depends on SND_SOC
> + depends on DRM_DW_HDMI
> + select SND_SOC_HDMI_CODEC
> + help
> + Support the I2S Audio interface which is part of the Synopsis
"Synopsis" -> "Synopsys"
> + Designware HDMI block.
> diff --git a/drivers/gpu/drm/bridge/synopsys/Makefile b/drivers/gpu/drm/bridge/synopsys/Makefile
> new file mode 100644
> index 000000000000..17aa7a65b57e
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/synopsys/Makefile
> @@ -0,0 +1,5 @@
> +#ccflags-y := -Iinclude/drm
> +
> +obj-$(CONFIG_DRM_DW_HDMI) += dw-hdmi.o
> +obj-$(CONFIG_DRM_DW_HDMI_AHB_AUDIO) += dw-hdmi-ahb-audio.o
> +obj-$(CONFIG_DRM_DW_HDMI_I2S_AUDIO) += dw-hdmi-i2s-audio.o
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> similarity index 100%
> rename from drivers/gpu/drm/bridge/dw-hdmi-ahb-audio.c
> rename to drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi-audio.h b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-audio.h
> similarity index 100%
> rename from drivers/gpu/drm/bridge/dw-hdmi-audio.h
> rename to drivers/gpu/drm/bridge/synopsys/dw-hdmi-audio.h
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi-i2s-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c
> similarity index 100%
> rename from drivers/gpu/drm/bridge/dw-hdmi-i2s-audio.c
> rename to drivers/gpu/drm/bridge/synopsys/dw-hdmi-i2s-audio.c
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> similarity index 100%
> rename from drivers/gpu/drm/bridge/dw-hdmi.c
> rename to drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> diff --git a/drivers/gpu/drm/bridge/dw-hdmi.h b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.h
> similarity index 100%
> rename from drivers/gpu/drm/bridge/dw-hdmi.h
> rename to drivers/gpu/drm/bridge/synopsys/dw-hdmi.h
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
