On Wed, Mar 01, 2017 at 04:01:05PM -0300, Gabriel Krisman Bertazi wrote:
> Daniel Vetter <daniel@xxxxxxxx> writes:
>
> > You forgot to update the kernel-doc, building them now generates new
> > warnings. Please fix in a follow-up patch.
>
> Hm, that´s a bummer. Please take the fix below. Thanks for spotting.
Applied, thx for the quick fix.
-Daniel
>
> -- >8 --
> Subject: [PATCH] drm: Update drm_fbdev_cma_init documentation
>
> Commit be7f735cd5ea ("drm: Rely on mode_config data for fb_helper
> initialization") dropped the num_crtc argument. Update the
> documentation to reflect that and prevent the kernel-doc warnings below:
>
> ./drivers/gpu/drm/drm_fb_cma_helper.c:557: warning: Excess function parameter 'num_crtc' description in 'drm_fbdev_cma_init'
> ./drivers/gpu/drm/drm_fb_cma_helper.c:558: warning: Excess function parameter 'num_crtc' description in 'drm_fbdev_cma_init'
>
> Fixes: be7f735cd5ea ("drm: Rely on mode_config data for fb_helper initialization")
> Signed-off-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/drm_fb_cma_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index be6d90664e50..74cd393a6407 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -547,7 +547,6 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_init_with_funcs);
> * drm_fbdev_cma_init() - Allocate and initializes a drm_fbdev_cma struct
> * @dev: DRM device
> * @preferred_bpp: Preferred bits per pixel for the device
> - * @num_crtc: Number of CRTCs
> * @max_conn_count: Maximum number of connectors
> *
> * Returns a newly allocated drm_fbdev_cma struct or a ERR_PTR.
> --
> 2.11.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
