On Mon, Feb 20, 2017 at 09:29:10AM +0100, Hans de Goede wrote: > Hi, > > On 16-02-17 20:02, Jani Nikula wrote: > > On Thu, 16 Feb 2017, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > > > On Fri, Feb 10, 2017 at 11:28:02AM +0100, Hans de Goede wrote: > > > > Listen for PMIC bus access notifications and get FORCEWAKE_ALL while > > > > the bus is accessed to avoid needing to do any forcewakes, which need > > > > PMIC bus access, while the PMIC bus is busy: > > > > > > > > This fixes errors like these showing up in dmesg, usually followed > > > > by a gfx or system freeze: > > > > > > > > [drm:fw_domains_get [i915]] *ERROR* render: timed out waiting for forcewake ack request. > > > > [drm:fw_domains_get [i915]] *MEDIA* render: timed out waiting for forcewake ack request. > > > > i2c_designware 808622C1:06: punit semaphore timed out, resetting > > > > i2c_designware 808622C1:06: PUNIT SEM: 2 > > > > i2c_designware 808622C1:06: couldn't acquire bus ownership > > > > > > > > Downside of this approach is that it causes wakeups whenever the PMIC > > > > bus is accessed. Unfortunately we cannot simply wait for the PMIC bus > > > > to go idle when we hit a race, as forcewakes may be done from interrupt > > > > handlers where we cannot sleep to wait for the i2c PMIC bus access to > > > > finish. > > > > > > > > Note that the notifications and thus the wakeups will only happen on > > > > baytrail / cherrytrail devices using PMICs with a shared i2c bus for > > > > P-Unit and host PMIC access (i2c busses with a _SEM method in their > > > > APCI node), e.g. an axp288 PMIC. > > > > > > > > I plan to write some patches for drivers accessing the PMIC bus to > > > > limit their bus accesses to a bare minimum (e.g. cache registers, do not > > > > update battery level more often then 4 times a minute), to limit the > > > > amount of wakeups. > > > > > > > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=155241 > > > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > > > Tested-by: tagorereddy <tagore.chandan@xxxxxxxxx> > > > > > > I gave the previous versions a quick whirl on a few machines here, but > > > them not being CR versions I guess this stuff doesn't kick in at all. > > > And I don't see any _SEM stuff in the DSDT/SSDT, so I guess that > > > confirms it. Which is fine since I've not seem any stability issues > > > on those machines. So at least nothing seemed to break :) > > > > > > Anyways the changes look all right to me, so for both i915 patches > > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > > > for merging the i915 patches through some other tree if that makes > > managing the pile easier. > > Actually the idea was for the entire pile to go through the drm-intel > tree. Daniel can you pick these up please (they seem to be ready) ? For the future: Both Ville and Jani have commit rights for drm-intel, Jani's even officially co-maintainer. No need to wait for me to get back from travelling at all. I'm applying them now, but only this time :-) Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
