On ma, 2017-02-20 at 13:12 +0100, Maarten Lankhorst wrote:
> Op 20-02-17 om 13:03 schreef Chris Wilson:
> >
> > On Mon, Feb 20, 2017 at 01:32:42PM +0200, Joonas Lahtinen wrote:
> > >
> > > Smells like a helper function? While that helper is finding the way
> > > upstream;
> > Blurgh.
> >
> > enum dma_fence_array_signal_mode {
> > DMA_FENCE_ARRAY_SIGNAL_ON_ALL = 0,
> > DMA_FENCE_ARRAY_SIGNAL_ON_ANY,
> > };
> >
> > enum dma_fence_array_signal_mode
> > dma_fence_array_get_signaling_mode(struct dma_fence_array *array)
> > {
> > return test_bit(DMA_FENCE_ARRAY_SIGNAL_ANY, &array->base.flags) ?
> > DMA_FENCE_ARRAY_SIGNAL_ON_ANY : DMA_FENCE_ARRAY_SIGNAL_ON_ALL;
> > }
> >
> > if (!dma_fence_is_array(fence) ||
> > dma_fence_array_get_signaling_mode(to_dma_fence_array(fence)) == DMA_FENCE_ARRAY_SIGNAL_ON_ANY)
> >
> > Hmm. Not happy with that yet.
> > -Chris
> >
> bool dma_fence_array_signal_on_any with a WARN_ON(!dma_fence_is_array(fence))?
I was also thinking along these lines.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
