Re: [PATCH 2/2] drm/ast: Support AST2500

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18 February 2017 at 03:41, Benjamin Herrenschmidt
<benh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 2017-02-17 at 21:27 +0000, Emil Velikov wrote:
>> Hi Ben,
>
>  .../...
>
>> Not sure why you opted for splitting each suggestion in separate
>> email, but it seems to have lead to a [serious] bugfix to go
>> unnoticed.
>
> Many thanks for your reviews. I've put a tentative new series there
>
> https://github.com/ozbenh/linux-ast
>
> I'm waiting for Aspeed to test on Monday on their HW (they can test
> the POST code) and I'll be testing again on POWER8 and POWER9 this
> week-end. If all goes well I'll send the new series to the list then.
>
Out of curiosity - can you try testing with and w/o the ddr_test_2500
bug fix(?).
Would be interesting to see if any of the omitted code [in
ast_dram_init_2500] has noticeable effect.

> I've changed my refactoring of mmc_test_* to be closer to the original
> code as I had missed a difference in loop exit condition.
>
The series looks a lot, better. Thank you for addressing my suggestions !

Regards
Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux