On Fri, Feb 17, 2017 at 05:14:47PM +0200, Jani Nikula wrote:
> Follow the naming in debugfs also for logging, add "unknown" for values
> beyond the enumerated ones.
>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
> +EXPORT_SYMBOL(drm_get_connector_force_name);
Do we need the symbol outside of drm-core? Mainly asking if you forsee a
user.
> diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c
> index 2290a74a6e46..a6385d4b598b 100644
> --- a/drivers/gpu/drm/drm_debugfs.c
> +++ b/drivers/gpu/drm/drm_debugfs.c
> @@ -261,30 +261,8 @@ int drm_debugfs_cleanup(struct drm_minor *minor)
> static int connector_show(struct seq_file *m, void *data)
> {
> - seq_puts(m, status);
> + seq_puts(m, drm_get_connector_force_name(connector->force));
Loses the trailing '\n'. It's not required, but it looks neater on the
terminal.
Two small questions,
Reviwed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
