On Thu, 2017-02-16 at 17:33 +0000, Emil Velikov wrote: > I realise that there's likely no documentation, yet repeating the > same > magic numbers multiple times is a bit meh. This is all Aspeed original code. I merely fixed the coding style ;-) The other POST functions for the other chip gens are the same in that regard. That said I do have the doc, I could create constants for everything but I really don't have that much time and we are in an emergency toget that into distros... What I might do is do a separate patch later that replaces a bunch of the hard coded values with properly defined constants. Cheers, Ben. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel