On Fri, Feb 10, 2017 at 06:48:06PM +0100, Thierry Reding wrote:
> On Fri, Feb 10, 2017 at 06:14:14PM +0100, Thierry Reding wrote:
> [...]
> > /**
> > - * drm_connector_list_iter_get - initialize a connector_list iterator
> > + * drm_connector_list_iter_begin - initialize a connector_list iterator
> > * @dev: DRM device
> > * @iter: connector_list iterator
> > *
> > * Sets @iter up to walk the &drm_mode_config.connector_list of @dev. @iter
> > - * must always be cleaned up again by calling drm_connector_list_iter_put().
> > + * must always be cleaned up again by calling drm_connector_list_iter_end().
> > * Iteration itself happens using drm_connector_list_iter_next() or
> > * drm_for_each_connector_iter().
> > */
> > -void drm_connector_list_iter_get(struct drm_device *dev,
> > - struct drm_connector_list_iter *iter)
> > +void drm_connector_list_iter_begin(struct drm_device *dev,
> > + struct drm_connector_list_iter *iter)
> > {
> > iter->dev = dev;
> > iter->conn = NULL;
> > lock_acquire_shared_recursive(&connector_list_iter_dep_map, 0, 1, NULL, _RET_IP_);
> > }
> > -EXPORT_SYMBOL(drm_connector_list_iter_get);
> > +EXPORT_SYMBOL(drm_connector_list_iter_end);
>
> Erm... this should obviously have been drm_connector_list_iter_begin, no
> idea why the build tests didn't catch this on the first run.
With gcc properly appeased:
Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>
Since you have drm-misc commit rights, want to test-drive by pushing the
entire pile to drm-misc-next? Iirc you've tried it with 2 panel patches a
few months back, pls note that you need to update the dim script and
re-run dim setup, since things changed a bit with the split-out of the
drm-misc.git repo.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
