On Mon, Feb 13, 2017 at 08:41:10AM +0100, Thierry Reding wrote: > On Fri, Feb 10, 2017 at 07:59:13PM +0000, Chris Wilson wrote: > > The warnings from parsing the EDID are not driver errors, but the > > "normal but significant" conditions from the external device. As such, > > they do not need the ferocity of an *ERROR*, but can use the less harsh > > DRM_NOTE instead. > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/drm_edid.c | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > The below are all conditions that happen when the EDID is bad. I'm not > sure that really qualifies as "normal". Often it is - a bad EDID on the monitor will always be bad. The challenge is distinguishing that from silent data corruption during the read - a reported read failure are trivial. > From a quick look through the code we don't always trigger an error from > the below failure paths at higher levels, so decreasing the level here > has the potential to let this kind of exceptional condition go > unnoticed. The messages are not gone, they are higher than the default loglevel, but now below the level at which they are printed to a terminal. The bad EDID is either expected or recoverable, and definitely not fatal so I don't think an *ERROR* is justified. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
