Re: [PATCH] drm/imx: imx-tve: Make the 'dac' regulator optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2017-02-03 at 10:52 -0200, Fabio Estevam wrote:
> Hi Philipp,
> 
> On Tue, Jan 3, 2017 at 5:11 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> > From: Fabio Estevam <fabio.estevam@xxxxxxx>
> >
> > Commit deb65870b5d9d ("drm/imx: imx-tve: check the value returned by
> > regulator_set_voltage()") exposes the following probe issue:
> >
> > 63ff0000.tve supply dac not found, using dummy regulator
> > imx-drm display-subsystem: failed to bind 63ff0000.tve (ops imx_tve_ops): -22
> >
> > When the 'dac' regulator is not passed in the device tree,
> > devm_regulator_get() will return NULL and when regulator_set_voltage()
> > is called it returns an error.
> >
> > Fix the issue by making the 'dac' regulator optional.
> >
> > Fixes: deb65870b5d9d ("drm/imx: imx-tve: check the value returned by regulator_set_voltage()")
> > Cc: <stable@xxxxxxxxxxxxxxx> # 4.8+
> > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> 
> Any comments, please?

I've applied this to the fixes branch, since the current device trees
don't have the regulator set.

Is this really optional, though? It would be better to add the correct
dac-supply to the device trees.

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux