On Tue, Feb 07, 2017 at 09:34:01AM +0800, Mark Yao wrote:
> fix warning:
>
> drivers/gpu/drm/rockchip/cdn-dp-reg.c:632:24: warning:
> 'val[1]' may be used uninitialized in this function [-Wmaybe-uninitialized]
> msa_misc = 2 * val[0] + 32 * val[1] +
>
> Signed-off-by: Mark Yao <mark.yao@xxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-reg.c b/drivers/gpu/drm/rockchip/cdn-dp-reg.c
> index 3a5b8a4..319dbba 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-reg.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-reg.c
> @@ -592,7 +592,7 @@ static int cdn_dp_get_msa_misc(struct video_info *video,
> struct drm_display_mode *mode)
> {
> u32 msa_misc;
> - u8 val[2];
> + u8 val[2] = {0};
Kind of a nit, but it would be better to add default cases to the switches below so it's more
obvious which format/depth you consider the fallback.
Sean
>
> switch (video->color_fmt) {
> case PXL_RGB:
> --
> 1.9.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
