On Tue, Jan 24, 2017 at 08:55:35AM +0100, Daniel Vetter wrote: > On Sun, Jan 22, 2017 at 02:09:01PM +0800, Shawn Guo wrote: > > From: Shawn Guo <shawn.guo@xxxxxxxxxx> > > > > The vblank is mostly CRTC specific and implemented as part of CRTC > > driver. The first patch adds 3 vblank core-driver hooks into struct > > drm_crtc_funcs, and wraps around core vblank handling code to use the > > new hooks for modern MODESET drivers and the ones in struct drm_driver > > as fallback for legacy drivers. > > > > The other patches in the series are to demonstrate how the new hooks > > are going to influence the driver code. There are more drivers than > > the ones included here can be converted. But before doing that, I would > > like to get some feedbacks first, expecially on how .get_vblank_counter > > should be converted when it's being drm_vblank_no_hw_counter(). > > > > .get_vblank_counter = drm_vblank_no_hw_counter > > I dropped some suggestions about this onto patch 3. Thanks for doing this, > I think it looks rather pretty. Just to check: Do you plan to resend this series with my comments on the first patch addressed? I really like this, so I guess you could drop the RFC part and then we give maintainers a week or two for reviews and land it into drm-misc for 4.12 ... -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
